Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symbol collection text should not be surrounded in a white box #60

Open
esaule opened this issue Oct 26, 2020 · 6 comments
Open

symbol collection text should not be surrounded in a white box #60

esaule opened this issue Oct 26, 2020 · 6 comments

Comments

@esaule
Copy link
Member

esaule commented Oct 26, 2020

It seems that text in the symbol collection is framed in a rectangle that is painted (stroke) white, it should probably be stroke none (or whatever it is called in svg).

I attach a pdf that shows what it does
hashed-shakespeare.pdf

(I had to export the SVG to inkscape to understand that is what the problem is.)

@esaule
Copy link
Member Author

esaule commented Oct 26, 2020

That would be in https://github.com/BridgesUNCC/bridgesAPI/blob/master/public/js/collection.js

The code draws a bounding box around the text, I am not sure why it is doing that. @krs-world do you know?

There does not seem to be a way in the client to control that bounding box. Actually there isn't even a way to print text in different colors.

@krs-world
Copy link
Contributor

I do remember working with this code, but focused only the way the transforms being made on the symbols. I can take a look, as the code looks somewhat familiar!

You need this yesterday for what you are doing now, right?

@esaule
Copy link
Member Author

esaule commented Oct 26, 2020

no, I don't need it right away.
The picture looks ugly, but it is readable enough to be usable.

I think we need to take some time eventually to figure out what we exactly want for these symbol collection. We could replicate the SVG standard as a bridges API but that is clearly overkill. We probably want something much simpler. But putting colors on text label seems an obvious thing to have.

I really like the ability to craft visualization that bridges wasn't designed for. So the question becomes what are the different use cases and can we support them with what we have.

There are also questions of not changing the API behavior too often because it breaks previous code (I have to readjust how hashtable visualization works ion 8-PQBook).

I think we can take our time to do what is right.

@esaule
Copy link
Member Author

esaule commented Oct 26, 2020

Also, I don't think we added a box around textlabel for no reason. We had a reason to do that. Just cutting the text label could break our previous use case that I can't think of right now.

@krs-world
Copy link
Contributor

We can make it an option, perhaps, then. Have an API call to set border or something..

@esaule
Copy link
Member Author

esaule commented Oct 27, 2020

(I put it there because I am not sure where to put cross client related issues.)

There is inconsistencies inclient behavior regarding symbol collection. It seems the python implementation has an auto set feature for the viewport while the C++ one does not do it. I'll look at the java one soon.

I think we should have all client auto set the viewport unless it is explicitely overriden by a call to setViewport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants