Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support Polly Context #1197

Open
iancooper opened this issue Jul 16, 2020 · 0 comments
Open

[Feature] Support Polly Context #1197

iancooper opened this issue Jul 16, 2020 · 0 comments

Comments

@iancooper
Copy link
Member

Is your feature request related to a problem? Please describe.
We cannot access the Polly Context in a policy, to allow logging for example, because we do not use the version of ExecuteAsync which supplies a context

Describe the solution you'd like
Pass a Polly Context to the ExecuteAsync call. We may need to use our own internal context to transport a Polly Context through to the handler site. Consumers can then set the Polly Context in the context bag and thus pass values into the call handling site.

Describe alternatives you've considered
There are few options around the pipeline that allow us to access the Polly context when logging. We might be able to log the exception that bubbles out of Polly etc. but we don't get to see the parameters of the retry or fallback

Additional context
Polly Contexts: https://github.com/App-vNext/Polly/wiki/Keys-and-Context-Data

@iancooper iancooper self-assigned this Jul 16, 2020
@iancooper iancooper removed their assignment Oct 13, 2021
@iancooper iancooper changed the title Support Polly Context [Feature] Support Polly Context Apr 18, 2023
@iancooper iancooper removed the v9.next label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant