-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
d2l-status-indicator
-- can we have a setting to not transform the text?
#4241
Comments
Just seeing this now, sorry -- I think it would be better to drop the text-transform altogether. To do that, I think we'd need to find existing lang terms used in status indicators to address any impact. It seems unlikely anyone would use all lower case, but we may find some cases where the lang terms were set to all uppercase (which we later tried to discourage due to readability and screen reader concerns). |
Thanks @geurts and @dbatiste! On my end, for the nova repo, I'm going to create a simple wrapper we can use temporarily until the component is updated. Let me know if you need any more info from me or if I can help out somehow Edit: actually that seems like a lot to undo later, it is simpler to handle the specific cases we need and then change those when the update is done so I'll go with that... Edit edit: I actually keep going back and forth in my head on what to do so decided to check with team 😄 |
In Wave, we love the
d2l-status-indicator
-- but currently we are overridingtext-transform: capitalize
with CSS for things like '1 of 2 Approved' as well as French lang terms which are multiple words, which we don't want capitalized.It would be cool -- not necessary, but cool -- if we could provide some bool property to the
d2l-status-indicator
that disables thetext-transform: capitalize
CSS without needing to override it or wrap our own component.Maybe this goes against the principal of keeping statuses one word -- however sometimes single words in English become multiple words in other languages... and it would be nice to have some easier & consistent way to control the capitalization.
The text was updated successfully, but these errors were encountered: