Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding support to fr-ON custom locale #85

Merged
merged 1 commit into from
Mar 31, 2021
Merged

feat: adding support to fr-ON custom locale #85

merged 1 commit into from
Mar 31, 2021

Conversation

dlockhart
Copy link
Member

Was hoping we'd avoid needing to deal with the non-standard fr-ON locale in here, but because we (correctly) inherit date/time/number settings from the base fr instead of fr-CA, we need to handle it specially.

@dlockhart dlockhart requested a review from bearfriend March 30, 2021 21:41
@bearfriend
Copy link
Contributor

bearfriend commented Mar 30, 2021

Do we actually just want to change fr to be a copy of fr-CA, since that's what our other language/locale fallbacks do? That way we'd avoid fr-ON altogether and fr-* would get both fr-CA translations (where serge rewrites are correct 🤞) and dates etc.

Copy link
Contributor

@bearfriend bearfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. This does make sense, I'm just now wondering why fr-CA should even be the fallback for translations.

@dlockhart
Copy link
Member Author

Do we actually just want to change fr to be a copy of fr-CA

That would certainly make the change easier, and also be consistent with how the monolith handles things. But generally I don't think it's how these things should work... but who knows. The monolith works this way because for many years, we only had clients in fr-CA -- it's only recently that we've needed to support fr-FR (same for es-MX and es-ES).

@dlockhart dlockhart merged commit 58ca1a1 into master Mar 31, 2021
@dlockhart dlockhart deleted the fr-on branch March 31, 2021 13:55
@ghost
Copy link

ghost commented Mar 31, 2021

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants