feat: adding a useGrouping option for number formatting #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within our number input web component, we've decided that we'd like to suppress showing the thousand separators in the input itself. These can be confusing to see in an input, especially when you're trying to change a value by adding/removing digits -- in these cases you need to fix where the thousand separators are before it'll validate.
This is why it's not common to see thousand separators in number inputs --
<input type="number">
doesn't show them, and tools like Excel/Google Sheets only show them where a number is rendered, not where it's inputted.This change adds an option to suppress thousand separators from
formatNumber()
-- it follows the same naming convention as the native Intl NumberFormat does.