fix Safari 14.1 NumberFormat issue #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
margaree
approved these changes
Jun 17, 2021
|
🎉 This PR is included in version 3.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a weird issue with
Intl.NumberFormatthat Apple introduced in Safari 14.1 that only affects macOS Mojave users (10.14). If you use thesignDisplayoption, it throws an exception with the messageFailed to initialize NumberFormat since used feature is not supported in the linked ICU version. This is not a problem on later versions of macOS.Our usage here of the
signDisplayoption wasn't necessary anyway, since we take the absolute value of the number on the line above and then add in the negative symbol later anyway.Apple has addressed the issue, but it's not clear when that will be released.