Added helpers for formatting timezones #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronan-f
commented
Nov 26, 2021
lib/dateTime.js
Outdated
| @@ -1128,10 +1128,24 @@ export function formatDateTime(date, options) { | |||
|
|
|||
| } | |||
|
|
|||
| export function formatDateTimeFromTimestamp(timestamp, options) { | |||
| function parseLocalDateTimeFromTimestamp(timestamp, options) { | |||
There was a problem hiding this comment.
Methods which return JS Date objects seem to be named parse<dateFormat> so I tried to keep that consistent here.
margaree
reviewed
Nov 29, 2021
margaree
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Looks good! Do you have merging permissions? If so, when you merge if you append feat: to the merge commit message then it will update the version (https://github.com/BrightspaceUI/intl#versioning--releasing)
|
🎉 This PR is included in version 3.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose we add the following methods to the date time helpers:
formatDateFromTimestampformatTimeFromTimestampThis seems consistent with the other formatting helpers which provide options for formatting the date or time individually and allows more flexibility for consumers using timestamps.
Another thought I had was to expose the
parseLocalDateTimeFromTimestampmethod and allow consumers to format the resultingDateobject however they want. I'm not sure if that would be a preferable option in this case.