feat: upgrading visual-diff #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlockhart
force-pushed
the
dlockhart/esm
branch
from
d031fad
to
96d1fce
Compare
svanherk
approved these changes
Dec 6, 2021
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By switching to the new
mainbranch of the actions repo, you pick up the latest visual-diff, mocha@9 and puppeteer@12 -- this will likely case minor visual differences.If you've seen me make this change in other repos, this PR is different. I didn't switch the whole thing to ESM because
polymer-clidoesn't like it, and it would require dealing with Gulp and some other things. We can make that switch when this project is converted to Lit. This did mean the visual-diff files need the.mjsextension.