Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip position #167

Merged
merged 1 commit into from
Jul 18, 2022
Merged

fix: tooltip position #167

merged 1 commit into from
Jul 18, 2022

Conversation

dlockhart
Copy link
Contributor

@dlockhart dlockhart commented Jul 18, 2022

Missed this one compared to the others -- we always want these opening down otherwise they open to the right and cover over other things in the nav.

@dlockhart dlockhart requested a review from a team as a code owner July 18, 2022 20:32
@dlockhart dlockhart merged commit 782cd16 into main Jul 18, 2022
@dlockhart dlockhart deleted the dlockhart/tooltip-position branch July 18, 2022 20:53
@ghost
Copy link

ghost commented Jul 18, 2022

🎉 This PR is included in version 5.7.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jul 18, 2022
@dcostiuc
Copy link

dcostiuc commented Jul 18, 2022

on cover over other things in the nav.

Sorry, what do you mean by this?

What would be the issue with it opening to the right instead of always down?

@dlockhart
Copy link
Contributor Author

Sorry I meant to say "and cover over things in the nav".

To the right:
Screen Shot 2022-07-18 at 5 40 20 PM

Down:
Screen Shot 2022-07-18 at 5 40 40 PM

It's always going to cover something, but the rest go down so I think the consistency is nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants