Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: link-icon height #168

Merged
merged 3 commits into from
Jul 22, 2022
Merged

fix: link-icon height #168

merged 3 commits into from
Jul 22, 2022

Conversation

dlockhart
Copy link
Contributor

@dlockhart dlockhart commented Jul 18, 2022

Aligning this with d2l-navigation-link-image, d2l-navigation-link and d2l-navigation-link-back as it's behaving slightly different in the LMS than in the demos due to the container the LMS is using.

Not expecting a visual-diff change 🤞 .

@dlockhart dlockhart requested a review from a team as a code owner July 18, 2022 21:00
@github-actions
Copy link
Contributor

Visual diff tests failed - pull request #169 has been opened with the updated goldens.

github-actions bot and others added 2 commits July 18, 2022 17:05
Co-authored-by: github-actions <github-actions@github.com>
@dlockhart dlockhart merged commit 8a7188c into main Jul 22, 2022
@dlockhart dlockhart deleted the dlockhart/fix-height branch July 22, 2022 14:48
@ghost
Copy link

ghost commented Jul 22, 2022

🎉 This PR is included in version 5.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants