feat: remove <d2l-navigation-button> #183
Conversation
| import '@brightspace-ui/button/d2l-button-behavior.js'; | ||
| import '@brightspace-ui/polymer-behaviors/d2l-focusable-behavior.js'; | ||
| import '@brightspace-ui/polymer-behaviors/d2l-id.js'; | ||
| import { highlightStyles } from './d2l-navigation-highlight-styles.js'; |
There was a problem hiding this comment.
This and polymer-behaviors are still used by <d2l-navigation-link> -- so close!
| @@ -56,7 +55,6 @@ | |||
| "stylelint": "^14" | |||
| }, | |||
| "dependencies": { | |||
| "@brightspace-ui/button": "^6", | |||
|
Looks like Consistent Eval still uses it? https://github.com/Brightspace/consistent-evaluation/blob/master/components/footer/consistent-evaluation-footer.js#L130-L139 |
Ugh, my GitHub search for |
|
I tried |
|
Alright, I can't find any other references other than the one mentioned in the PR description. |
|
🎉 This PR is included in version 5.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ghost
added
the
All usages of this have been replaced with either
<d2l-navigation-button-icon>or<d2l-navigation-dropdown-button-*>! 🎉There's one remaining usage in nova-persona-manager but that project is still on the Lit 1 version of navigation, which doesn't have any of the new components. They're aware, and I've created a draft PR that they can just apply when they do the migration.