Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection in dark colour schemes are hard to find #52

Open
ghost opened this issue Jun 2, 2019 · 3 comments
Open

Selection in dark colour schemes are hard to find #52

ghost opened this issue Jun 2, 2019 · 3 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jun 2, 2019

Selection in dark colour schemes are hard to find

Please consider changing the colour.

gruvbox (dark) (hard):
1

gruvbox (dark) (medium):
2

gruvbox (dark) (soft):
3

Environment

gruvbox:

* version: 4.0.1
* installed via Package Control: True

Sublime Text:

* channel: stable
* version: 3207
* platform: linux
* architecture: x64

Dependency versions:

* mdpopups: Version could not be acquired!
* markdown: 2.6.11
* pygments: 2.1a0
* jinja2: 2.8
@Briles Briles self-assigned this Jun 9, 2019
@abdcdd
Copy link

abdcdd commented Aug 12, 2020

I'm facing the same issue (especially when having selected multiple same words and want to have an idea of where they are by peeking minimap) and it'd be really great if gruvbox can have an option to adjust selected text foreground/background color!
Currently I'm working this around by using PackageResourceViewer to edit gruvbox color scheme by changing:
"selection": "var(bg1)",
to
"selection": "var(red)",
but there doesn't seem to be an option to edit selected foreground color so now selected texts are now in their original color with a red background, which seems a little emmmmmm funny :D

@Briles
Copy link
Owner

Briles commented Dec 6, 2020

I'll look into improving the visibility of the selection background. It's tricky to find a highlight color that is easily distinguishable in a sea of syntax-highlighted code, the highlighted foreground included.

In the meantime, there's always the option of customizing the color theme to your liking. Assuming you don't already have any customizations, you can add a Packages/User/gruvbox (Dark) (Medium).sublime-color-scheme file (but replace the file name with the same one as the scheme you're currently using) with something like this to customize the selection styling:

{
    "globals":
    {
        // The background color of selected text
        "selection": "hsl(70, 0%, 15%)",
        // A color that will override the scope-based text color of the selection
        "selection_foreground": "hsl(70, 0%, 15%)"
    }
}

@BarbzYHOOL
Copy link

in another color scheme I did

    "globals":
    {
        "selection": "darkslategrey",
    },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants