Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small point about the coding #7

Open
cnyanhao opened this issue Mar 6, 2019 · 2 comments
Open

Small point about the coding #7

cnyanhao opened this issue Mar 6, 2019 · 2 comments

Comments

@cnyanhao
Copy link

cnyanhao commented Mar 6, 2019

Great work, thank you!
Here is my questions. In the script 'network_architectures.py', many 'pool3's are defined but 'pool2's are used instead. Like this

2019-03-06 10 31 08

Maybe it's not very good even though it doesn't matter.

Another question is that I found the 'Self-Ensembling' algorithm had been integrated into the library 'salad' (https://domainadaptation.org/). I'm wondering if this is consistent with your algorithm and if I can use 'salad' directly.

Thank you again for your great job!

@Britefury
Copy link
Owner

Woops! Thanks for spotting that!

Thanks for pointing me to Salad. I had seen it a while back and lost the link, so thanks! They seem to get the results that we would expect, although I don't think they use the specific augmentation necessary to crack MNIST -> SVHN. I haven't checked their code yet.

@Britefury
Copy link
Owner

Hi, I just pushed a new version that fixes the coding issues and is now more compliant with PyTorch v1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants