Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outputted diffusion bval are not the effective b-values anymore #95

Closed
jeremie-fouquet opened this issue Oct 25, 2022 · 4 comments
Closed

Comments

@jeremie-fouquet
Copy link
Contributor

Describe the bug
Since commit de6cb1e, the bvals are read from PVM_DwBvalEach instead of PVM_DwEffBval. This has two effects

  1. The outputted .bval file contains the requested bval instead of the effective bvals. I would argue the effective values are much more useful.
  2. By default, the bvals do not hold the b0 values anymore. The way this was handled led to the ordering problem described in issue Ordering of BVAL/BVEC in DTI data #90.

Suggested solution
I'd suggest going back to getting the bval from PVM_DwEffBval. It would solve both points mentioned above. @dvm-shlee, do you agree?

@araikes
Copy link

araikes commented Nov 18, 2022

@jeremie-fouquet,

I have a question about the effective bvals and manipulating them for Bruker systems. Do you have an email address I can send my question to as it is not directly relevant to brkraw?

Thanks

@jeremie-fouquet
Copy link
Contributor Author

Yes, sure.

jeremie.fouquet.comtl@ssss.gouv.qc.ca

@araikes
Copy link

araikes commented Nov 18, 2022

Great. Thanks. Sent you an email.

@jeremie-fouquet
Copy link
Contributor Author

Fixed by pull request #96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants