Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.encode(type, quality) 当 type 为 webp 时 quality 默认值会是 92 #407

Closed
meloalright opened this issue Jan 18, 2022 · 2 comments
Closed

.encode(type, quality) 当 type 为 webp 时 quality 默认值会是 92 #407

meloalright opened this issue Jan 18, 2022 · 2 comments

Comments

@meloalright
Copy link
Contributor

meloalright commented Jan 18, 2022 •
edited
Loading

看起来本来预期是 80

应该直接原因是这里导致的

canvas/index.js

Line 240 in 552a68e

return canvasEncode.call(this, type, qualityOrConfig || 92)

@meloalright meloalright changed the title Here might be wrong? 这里是不是写错了 Here might be wrong ? 这里是不是写错了 Jan 18, 2022
@Brooooooklyn
Copy link
Owner

/cc @yisibl

@meloalright meloalright changed the title Here might be wrong ? 这里是不是写错了 This if expression might be wrong ? 这里的判断是不是写错了 Jan 18, 2022
@meloalright meloalright changed the title This if expression might be wrong ? 这里的判断是不是写错了 .encode(type, quality) 第二个参数默认值不合预期 Feb 4, 2022
@meloalright meloalright changed the title .encode(type, quality) 第二个参数默认值不合预期 .encode(type, quality) 第二个参数默认值会一直是 92 Feb 4, 2022
@meloalright meloalright changed the title .encode(type, quality) 第二个参数默认值会一直是 92 .encode(type, quality) 当 type 为 webp 时 quality 默认值会是 92 Feb 4, 2022
@meloalright
Copy link
Contributor Author

Title changed

@meloalright meloalright mentioned this issue Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Brooooooklyn @meloalright