New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare seems not correct #269

Closed

AielloChan opened this issue Mar 20, 2024 · 1 comment · Fixed by #271

Contributor

AielloChan commented Mar 20, 2024

import { compare as fastCompare } from '@napi-rs/pinyin';

const a = '你好';
const b = '123';

console.log(fastCompare(a, b), fastCompare(b, a)); // -1 -1

Contributor Author

AielloChan commented Mar 20, 2024

compare('饿', '鹅') // -1 Wrong

鹅é、饿è

ē、é、ě、è

So compare('饿', '鹅') need to be 1

This was referenced Mar 20, 2024

fix(compare): Compare with tone #270

Closed

fix(compare): Compare with tone #271

Merged

Brooooooklyn closed this as completed in #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment