Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser-sync rewrites every redirect #381

Closed
aaronjensen opened this issue Jan 3, 2015 · 2 comments · May be fixed by tobybellwood/govstrap#4
Closed

browser-sync rewrites every redirect #381

aaronjensen opened this issue Jan 3, 2015 · 2 comments · May be fixed by tobybellwood/govstrap#4
Labels

Comments

@aaronjensen
Copy link

It seems like browser-sync is rewriting off-domain redirects while in proxy mode. For example, if we redirect to https://www.google.com from our app, browsersync will rewrite the direct to https://localhost:8080/ which is not what we want. I couldn't figure out if it was foxy doing this or browser-sync, but it's preventing us from using google oauth in dev mode through browser-sync.

shakyShane added a commit to shakyShane/foxy that referenced this issue Jan 3, 2015
@shakyShane shakyShane added the bug label Jan 3, 2015
@shakyShane
Copy link
Contributor

Confirmed - this is a bug with node-http-proxy (which my Foxy modules uses) https://github.com/nodejitsu/node-http-proxy/blob/master/lib/http-proxy/passes/web-outgoing.js#L49-L57

Basically the location header rewriting is being a bit brutal and just applying it to every url.

@shakyShane
Copy link
Contributor

Fixed at browser-sync@1.8.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants