Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding return types to the code? #9

Open
NicoHaase opened this issue Nov 10, 2022 · 1 comment
Open

Adding return types to the code? #9

NicoHaase opened this issue Nov 10, 2022 · 1 comment

Comments

@NicoHaase
Copy link

I really love the idea of using speed reports in Behat tests, but since one of the last PHP updates, there's a huge stacktrace written to my log when running Behat with XDebug enabled:

PHP Deprecated: Return type of Brunty\Behat\SpeedtrapExtension\Logger\ScenarioLogger::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/html/project/vendor/brunty/behat-speedtrap/src/Logger/ScenarioLogger.php on line 34

Is there any chance to revive this project, even for such a possible small change?

@Brunty
Copy link
Owner

Brunty commented Nov 16, 2022

That's something I can look into at somepoint over the Christmas period I'm sure (alternatively, I'd be open to a PR adding this!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants