Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUDI-7407] Selecting "None" as a data provider's sort column should keep rows in their original order #11554

Closed
1 task done
andz-bb opened this issue Aug 18, 2023 · 2 comments
Labels
bb-datasource bug Something isn't working linear Medium priority Created by Linear-GitHub Sync
Milestone

Comments

@andz-bb
Copy link
Contributor

andz-bb commented Aug 18, 2023

Checklist

  • I have searched Budibase discussions and GitHub issues to check if my issue already exists

Hosting

  • Self
    • Method: cloud
    • Budibase Version: 2.9.23
    • App Version: 2.9.23

Describe the bug
When you choose None as the sort column for a data provider, it should leave the data from the server in its original order rather than choosing the first column behind the scenes and sorting by that.

To Reproduce
Steps to reproduce the behaviour:

  1. Create a REST API query with multiple items on the response
  2. Use that query in a data provider and ensure that None is selected for the sort column
  3. See that the data provider is sorting the results by the first column rather than leaving them in the original order from the api response.

Expected behaviour
Default should be added to the picker with the current functionality where the data is sorted by the first column

None should also be an available option for the Sort Column, and when selected, would mean that the rows in the data provider are presented in their original order from the server.

Screenshots

image.png

Context

Raised in this GitHub discussion

From SyncLinear.com | BUDI-7407

@andz-bb andz-bb added bb-datasource Medium priority Created by Linear-GitHub Sync labels Aug 18, 2023
@aptkingston
Copy link
Member

This will be fixed as part of the views V2 PR (it's already fixed on that branch).

If you leave "sort column" at "default" then it will either do no sorting at all (e.g. most datasources) or use the built in sorting (view V2s).

"sort order" will also not appear as a setting unless "sort column" is defined.

@aptkingston aptkingston mentioned this issue Aug 29, 2023
@melohagan melohagan added the bug Something isn't working label Dec 11, 2023
@melohagan
Copy link
Collaborator

Appears to be fixed!

@andz-bb andz-bb added this to the v.1 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bb-datasource bug Something isn't working linear Medium priority Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

4 participants