Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen generation UX should make it clear that only datasource plus are supported #15189

Open
1 task done
hilton opened this issue Dec 16, 2024 · 3 comments
Open
1 task done
Assignees
Labels
enhancement New feature or request

Comments

@hilton
Copy link

hilton commented Dec 16, 2024

Checklist

  • I have searched budibase discussions and github issues to check if my issue already exists

Hosting

  • Cloud
    • Tenant ID: hilton

Describe the bug
On the Design / Create new screen page, after selecting Table or Form, no datasources are listed.

To Reproduce

  1. Create a new app
  2. Add a REST API datasource, with a query for GET https://cdn.githubraw.com/Juriy/swapi/refs/heads/master/resources/fixtures/films.json
  3. In the query, add a transformer return data.map(film => film.fields)
  4. Save the query
  5. In the Design view, select Table

Expected behavior
On the Autogenerated screens modal, after the text Select which datasources you would like to use to create your screens there is a way to select the REST API datasource.

Screenshots
Observed: no option to select a datasource.

Budibase - select datasource

Desktop:

  • OS: macOS 15.1.1
  • Browser: Safari 18.1.1
@hilton hilton added the bug Something isn't working label Dec 16, 2024
Copy link

linear bot commented Dec 16, 2024

@mikesealey
Copy link
Collaborator

Hey @hilton - I believe this is working as intended.

Looking at the code here: https://github.com/Budibase/budibase/blob/master/packages/builder/src/pages/builder/app/%5Bapplication%5D/design/_components/NewScreen/DatasourceModal.svelte we can see that rest entities are excluded as part of the getDatasources function on line 44.

@hilton
Copy link
Author

hilton commented Dec 16, 2024

@mikesealey Thank for for the quick response. That is… a surprising design decision, given that the conventional meaning of datasource is that it’s an abstraction that you can use interchangeably with other data sources. I guess this is a UX issue then, as neither UI nor docs made me aware of the limitation.

@mike12345567 mike12345567 changed the title Datasource not listed when adding autogenerated screens Screen generation UX should make it clear that only datasource plus are supported Dec 16, 2024
@mike12345567 mike12345567 added enhancement New feature or request and removed bug Something isn't working labels Dec 16, 2024
@andz-bb andz-bb self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants