Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from pydantic to attrs #4

Open
astronuttt opened this issue Aug 31, 2022 · 0 comments
Open

Migrate from pydantic to attrs #4

astronuttt opened this issue Aug 31, 2022 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@astronuttt
Copy link
Member

choosing Pydantic was not a wise decision at the start of the project!

it has a lot of overhead, and performance loss and we don't need most of its functionality and things that it brings, since we don't want to do any excessive data validation.

my suggestion is to migrate to attrs before we go any further in the project. I think now is the best time to do this, because if we don't, we may need to change a lot of things in the future.

@astronuttt astronuttt added enhancement New feature or request help wanted Extra attention is needed labels Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant