Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the wiki::search module #217

Closed
4 tasks done
Builditluc opened this issue Aug 14, 2023 · 0 comments · Fixed by #224
Closed
4 tasks done

Rewrite the wiki::search module #217

Builditluc opened this issue Aug 14, 2023 · 0 comments · Fixed by #224
Assignees
@Builditluc
Labels
state: approved This issue or pull request was approved and can be worked on type: refactor Changes to the style and structure of the codebase or project
Milestone
Version 0.9.0

Comments

@Builditluc
Copy link
Owner

Builditluc commented Aug 14, 2023 •
edited
Loading

Linked to #216

This issue describes the changes to the wiki::search module that are already outlined in #216. The following things would need to be done:

  • 3a05d9a
    Only use one method for accessing the data within Search (make the values public and remove the getter methods)
  • 5a1f133
    Create a separate data struct for continuing the search (SearchContinue)
  • b71ecb4
    Modify the properties of SearchResult so that we can open the article without accessing values from Search (on_article_submit would require a SearchResult)
  • 5fa8384
    Document the entire module with comments and links to the mediawiki api documentation
  • [ ] Move the module into the wiki-tui library Not possible, we would have to move parse_languages into its own proc_macro crate
@Builditluc Builditluc added state: approved This issue or pull request was approved and can be worked on type: refactor Changes to the style and structure of the codebase or project labels Aug 14, 2023
@Builditluc Builditluc self-assigned this Aug 14, 2023
@Builditluc Builditluc mentioned this issue Aug 14, 2023
Closed
@Builditluc Builditluc moved this from Todo to In Development in wiki-tui: Roadmap Aug 14, 2023
@Builditluc Builditluc linked a pull request Aug 17, 2023 that will close this issue
Rewrite the wiki::search module #224
Merged
@Builditluc Builditluc mentioned this issue Aug 17, 2023
Merged
@github-project-automation github-project-automation bot moved this from In Development to Done in wiki-tui: Roadmap Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Builditluc Builditluc

Labels
state: approved This issue or pull request was approved and can be worked on type: refactor Changes to the style and structure of the codebase or project
Projects
wiki-tui: Roadmap
Status: Done
Milestone
Version 0.9.0
Development

Successfully merging a pull request may close this issue.

Rewrite the wiki::search module Builditluc/wiki-tui
1 participant
@Builditluc