Incompatibility with MidnightControls

[LPDawid]

What went wrong?

Minecraft crashes when loading a world. Most of the time, screen with:

"Building terrain
Completed / Goal
Preparing All Chunks: x/x
Building Visible Chunks: x/x"

does not appear, making "Starting Session" screen the last before crash. Sometimes this screen is visible, but chunks status is not updated, frozen at 1-50/x in preparing and at 0/x in building. Loading time before crash is similar in both cases. If a new world is created, it will be saved and can be loaded later if one of the affected mods is disabled.

Reproduction steps

Mod combination affected:
FastLoad 3.2-3.4
MidnightControls 1.7.3-1.8.1

Disabling one of affected mods fixes crashes.

No other mod, plugin, data pack, shader, resource pack loaded.

Last working mod combination:
FastLoad 3.1.1
MidnightControls 1.7.3-1.8.1

Crash Report & Log

Debug in FastLoad is set to true.

Logs for 3.3.8
crash-2023-04-27_17.02.54-client.txt
latest.log.txt
20230427-1.json.txt

Logs for 3.4
crash-2023-05-04_13.14.02-client.txt
latest.log.txt
20230504-1.json.txt

Environment

Steam Deck, SteamOS 3.4.6, Prism Launcher 6.3 (flatpak stable), Fabric Loader 0.14.19,
(Minecraft 1.19.3, Fabric API 0.76.1) or (Minecraft 1.19.4, Fabric API 0.80)

[Kichura]

Can confirm, Workaround at the moment is to switch to using mouse & keyboard mode to join worlds and then switching back to controller mode once you are in.

[StockiesLad]

Tbh i got no idea how to solve this. Client is null for some reason... fastload isnt mentioned anywhere. Can you report this to midnight controls as well and link this page. I'm going to need to talk with to dev for this.

[StockiesLad]

can you re test with the latest jar. It has some important refactors that could resolve this. It seems like there is some overlap between this and ClientTickEvents of Fapi.

[StockiesLad]

i think it might be because fastload makes the world session begin earlier that midnight controls isn't prepared for it. Idk im just guessing

[LPDawid]

can you re test with the latest jar. It has some important refactors that could resolve this. It seems like there is some overlap between this and ClientTickEvents of Fapi.

Still happening in 3.4

[StockiesLad]

can you re test with the latest jar. It has some important refactors that could resolve this. It seems like there is some overlap between this and ClientTickEvents of Fapi.

Still happening in 3.4

Alright thanks for testing that.