Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform and transformRGBA are using the inverse of the given transform #2

Open
GoogleCodeExporter opened this issue Jan 29, 2016 · 0 comments

Comments

@GoogleCodeExporter
Copy link

It seems that this entire package uses *inverse* transformations from the usual 
convention.

This is borne out by examination of the Transform functions, which transform 
from the destination to the source to look up pixels.

In addition, each of the Rotate, Translate, etc. functions generates an inverse 
matrix (for example, Translate puts -x and -y in the translation terms; 
Rotation produces at clockwise rotation by documentation, while the matrix it 
provides usually produces a ccw rotation).

If this is intentional it needs to be clearly documented - providing your own 
affine transform doesn't work as expected - you have to invert it first.

To fix this we'd need to add an Invert() function and call it before the 
transformations.  I'm happy to provide a patch if this is the correct route.



Original issue reported on code.google.com by Paul.A.L...@gmail.com on 12 Jan 2012 at 7:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant