You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, thanks again for ripgrep! In delta we're using resolve_binary, and I have a question / feature request regarding its API (which I'm opening as a feature request issue). The second sentence of the docstring says "If the program could not be resolved, then an error is returned.", whereas in fact this is only true on Windows, as the last sentence says. This has caused me and others to make mistakes. My question is
Would a name like resolve_windows_binary have been a clearer name, or was there a reason not to do that?
And my feature request
Assuming a breaking renaming change is not reasonable, how about moving the final sentence of the docstring ("On non-Windows, this is a no-op.") up so that it becomes part of the first sentence of the docstring?
The text was updated successfully, but these errors were encountered:
Hi, thanks again for ripgrep! In delta we're using
resolve_binary
, and I have a question / feature request regarding its API (which I'm opening as a feature request issue). The second sentence of the docstring says"If the program could not be resolved, then an error is returned."
, whereas in fact this is only true on Windows, as the last sentence says. This has caused me and others to make mistakes. My question isresolve_windows_binary
have been a clearer name, or was there a reason not to do that?And my feature request
"On non-Windows, this is a no-op."
) up so that it becomes part of the first sentence of the docstring?The text was updated successfully, but these errors were encountered: