Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should ColorSpec be Copy? #43

Open
LPGhatguy opened this issue Jun 8, 2021 · 1 comment
Open

Should ColorSpec be Copy? #43

LPGhatguy opened this issue Jun 8, 2021 · 1 comment

Comments

@LPGhatguy
Copy link
Contributor

LPGhatguy commented Jun 8, 2021 •
edited
Loading

Some time ago, I filed (and fixed!) #8 to make Color copy.

Now I'm coming to ask about another type. Should ColorSpec be copy too? It seems like most functions take it by reference, so maybe it isn't worthwhile.
@BurntSushi
Copy link
Owner

Not sure. I don't see a strong reason to make it Copy to be honest. Is it likely that it will ever want to not be a POD data type? No, probably not. I can't think of any reason why it would every contain non-Copy data.

If you put up a PR, I'll noodle on it a bit more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BurntSushi @LPGhatguy