Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to emit attribute to disable rustfmt #18

Open
danielparks opened this issue Dec 30, 2019 · 1 comment
Open

Option to emit attribute to disable rustfmt #18

danielparks opened this issue Dec 30, 2019 · 1 comment

Comments

@danielparks
Copy link

Depending on how rustfmt is configured, it may try to reformat ucd-generate output. Add an option to emit #![rustfmt::skip] at the top of files created by ucd-generate so that rustfmt knows to skip them.

See rust-lang/regex#634 for an example where files generated by ucd-generate don’t match rustfmt’s configuration, which cause CI failures.

@BurntSushi
Copy link
Owner

I'm in favor of adding this, but this really isn't causing the CI failures. This is just kind of one of the hazards of putting a rustfmt check in CI. rustfmt evolves even if the code doesn't. Generated code is just as susceptible to this as regular code. Indeed, in regex's case, some hand-written files were also bitten by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants