Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.19.2] Pusher update will not check and push item in other slot after check slot 0 item #290

Open
gakongren opened this issue Jun 30, 2024 · 0 comments

Comments

@gakongren
Copy link

**Functional Storage Version: Found in 1.19.2-1.2.3, check in src code found problem exist in 1.18/1.19/main branch

Titanium Version:

**Crashlog If Applicable (Upload to pastebin/gist): No crash

I found this problem when I was trying to use a CompressDrawer to supply a Depolyer block(from mod: Create). I set the deployer use iron ingot as item input, which will be present in slot 1 off the compress drawer then it's supplying iron material (slot 0: iron nugget; slot 1: iron ingot; slot 2: iron block). But the pusher update is not working, the compress drawer will only push item in slot 0 to other item handler.
I found out the problem maybe is because by this:
image
When other handler will not accept the item insert, item count of pulled item stack is not modified; and since item is not changed, hasWorked flag shouldn't be marked, drawer should check next slot when item count is equaled, as-is no item will be inserted in this case.
I tried modify this code and it do seems this bug will fix. I also found that in case of puller update and collector update, it won't mark hasWorked flag when item count of item stack is not changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant