Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with does not accept OsStr #102

Open
ccyuen1 opened this issue Aug 2, 2024 · 1 comment
Open

with does not accept OsStr #102

ccyuen1 opened this issue Aug 2, 2024 · 1 comment
Labels
enhancement help wanted

Comments

@ccyuen1
Copy link

ccyuen1 commented Aug 2, 2024

Currently OsStr and OsString are not accepted as the app parameter of with, with_command, with_detached, and with_in_background. This does not make sense to me because OsStr should be suitable for interacting with the OS.

I can see that changing app: impl Into<String> to app: impl AsRef<OsStr> or app: impl Into<OsString> is a breaking change. Is there a way to overcome this?
@Byron
Copy link
Owner

Byron commented Aug 2, 2024

I don't think so, unless one would want to duplicate the API.

Instead, I'd probably just create a new breaking release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Byron @ccyuen1