-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filesystem time deletion to TrashItem #78
Labels
Comments
Byron
added
enhancement
New feature or request
help wanted
Extra attention is needed
labels
Jul 8, 2023
Thanks for reporting. Unifying the representation of time across platforms seems like a valuable addition, thanks for sharing. |
I made a pull request #79 to add this attribute |
Deleted PR, this change would actually make it harder to work cross-platform and would require checks for windows and unix separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'd like if the filesystem time of deletion was accessible for TrashItem elements, as in windows the std::fs times are not in i64 UNIX timestamp but in u64 windows filetime, and calculating differences requires converting back and forth between the two formats
The text was updated successfully, but these errors were encountered: