Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] - <Usage of UID instead of Labels in ServerCommands> #209

Open
SimobiSirOP opened this issue Dec 29, 2024 · 5 comments
Open

🐛 [BUG] - <Usage of UID instead of Labels in ServerCommands> #209

SimobiSirOP opened this issue Dec 29, 2024 · 5 comments
Labels
needs: help This issue or pull request needs help

Comments

@SimobiSirOP
Copy link
Contributor

Description

In order to use a player name as a argument, you should use his own UID.

This can confuse a lot of admins and server owners.

OS

Windows, Linux, Mac

Reproduction steps

1. Start the server
2. Join the server
3. Try to op yourself using nickname
4. You can't, you should use UID

Screenshots

No response

Client logs

Not needed for replication

Server logs

Not needed for replication
@Byte-Nova
Copy link
Owner

It's an intended change, the UID system now allows multiple users with the same username so it would be detrimental if commands used the username now that it isn't unique. Perhaps this could be softened by displaying a warning if an admin tries using a name instead of the UID

@SimobiSirOP
Copy link
Contributor Author

Our commands already work only when player is online(if this haven't been changed)

What if only 1 player with this specific username is online, it will work. If 2 or more, warning will be displayed?

@Byte-Nova
Copy link
Owner

Byte-Nova commented Dec 29, 2024

It could work that way, but there are also some commands that will target users even if they are disconnected, so the moment there are 2 or more people with the same username those would stop working. We could do a check the moment an input is given, and if it corresponds to an username that is duplicated just fall back and tell the admin to use the UID, regardless on if they are connected or not

@SimobiSirOP
Copy link
Contributor Author

Probably the best idea. But i think about identification of nicknames in console.

Some admins will have problems finding out 2 different TEST1 Players. (Example).

This can be fixed by some kind of tile identification system, probably with a console command. Any ideas?

@Byte-Nova Byte-Nova added the needs: help This issue or pull request needs help label Jan 3, 2025
@Erag0n001
Copy link
Contributor

Implemented #219 to help solve the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: help This issue or pull request needs help
Projects
None yet
Development

No branches or pull requests

3 participants