Skip to content

removed get_node_by_uuid cript.API feature #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

nh916
Copy link
Contributor

@nh916 nh916 commented Nov 13, 2023

Description

removed get_node_by_uuid cript.API feature. This method will be removed in later versions in favor of the single search cript.API.get_node_by_exact_match()

I thought it'd be a better idea to remove it from the SDK and not release it in this version because if users use it, and we remove it in the next version it will introduce a breaking change that will break their script and it will be a hassle, better to not introduce at all this version and work on it in the next version.

Changes

Tests

Known Issues

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.

Copy link

trunk-io bot commented Nov 13, 2023

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@nh916 nh916 requested a review from InnocentBug November 13, 2023 17:41
@nh916
Copy link
Contributor Author

nh916 commented Nov 13, 2023

@InnocentBug if you can please see if you can format it with trunk as I am running trunk fmt on my system through WSL, but it is not formatting anything or finding any issues

@InnocentBug
Copy link

done

@nh916
Copy link
Contributor Author

nh916 commented Nov 13, 2023

done

You are the best! ✅ 🚀

@nh916
Copy link
Contributor Author

nh916 commented Nov 13, 2023

it's a shame this had to go because I worked hard on it too, but the new feature will be even better!

@nh916 nh916 merged commit a9fabab into develop Nov 13, 2023
@nh916 nh916 deleted the remove-get_node_by_uuid-feature branch November 13, 2023 21:06
@nh916 nh916 mentioned this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants