Skip validation #411
Merged
Skip validation #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to
|
InnocentBug
commented
Nov 13, 2023
InnocentBug
force-pushed
the
skip-validation
branch
from
5f2ca0d to
fa19218
Compare
|
please be sure this targets the |
yeah, done for both. (and branches rebased) |
nh916
previously approved these changes
Nov 13, 2023
You are the best! |
nh916
reviewed
Nov 13, 2023
nh916
previously approved these changes
Nov 13, 2023
nh916
reviewed
Nov 14, 2023
|
I want to approve this but CI is failing |
should be fixed. |
nh916
approved these changes
Nov 15, 2023
| @@ -183,7 +183,7 @@ def extract_base_url(url): | |||
| invalid_schema = {"invalid key": "invalid value", "node": ["Material"]} | |||
|
|
|||
| # Test should be skipped | |||
| assert local_cript_api._is_node_schema_valid(node_json=json.dumps(invalid_schema), is_patch=False) is True | |||
| assert local_cript_api._is_node_schema_valid(node_json=json.dumps(invalid_schema), is_patch=False) is None | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed with @bearmit
A flag that disables partially the tests is being implemented.
At the moment we do not disable tests by default.
There is a text output that let's users know that they can disable the validation if needed.
Some checks are forced even as tests are disabled.
savenode.jsonChanges
I changed the logging text to let users know that they can disable the validation.
And marked forced checks as such, letting the user know that they can't be disabled and that if they have issues, they should enable the tests.
Tests
I added a test that checks, that a wrong node is accepted if tests are disabled, but detected if forced.
Known Issues
None.
Notes
If we decide to disable tests by default, we just have to change the default value for
cript.API.skip_validationtoTrue.Checklist
CONTRIBUTORS.md) in the pull request source branch.