Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why you need @types/node in dependencies? #770

Closed
Crusader4Christ opened this issue Feb 3, 2022 · 3 comments
Closed

Why you need @types/node in dependencies? #770

Crusader4Christ opened this issue Feb 3, 2022 · 3 comments

Comments

@Crusader4Christ
Copy link

fast-csv/packages/format/package.json

Line 40 in c6b833d

"@types/node": "^14.0.1",

Please guys can you move it to devDependencies? Our legacy code use ts3.6 so it can't work with @types/node above version 12.20.20
@bemon
Copy link

bemon commented Jul 19, 2022

Any idea why they didn't removed it yet ?

@Crusader4Christ
Copy link
Author

Any idea why they didn't removed it yet ?
I made the PR for them, but...
#774

@zackerydev
Copy link
Contributor

Fix for this is merged, it will land in the upcoming 5.0 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Crusader4Christ @bemon @zackerydev