Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[critical for v3-stable release] backend crash when trying to load an unsupported image file #1161

Closed
kswang1029 opened this issue Jul 27, 2022 · 1 comment · Fixed by #1163
Assignees
Labels
critical bug critical bug which is a showstopper for release

Comments

@kswang1029
Copy link
Contributor

Describe the bug
Usually this should not happen via the GUI as the default file list parser only include supported image formats in the resulting file list. However, in the preferences now we have an option to show all files so the file list can have all other unsupported files such as pdf, png, etc. Then if we single click on one, the file info shows it is unsupported as expected. However, if we double-click on one, the backend crashes...

To Reproduce
Steps to reproduce the behavior:

  1. set the "file list" dropdown menu in the "Global" tab of the preferences dialog to "all files"
  2. navigate to a folder with unsupported image formats, such as png or pdf
  3. single-click on one and backend should return an error message and the frontend shows it in the file info
  4. double-click on one and the backend should crash

Expected behavior
Backend should not crash in this case and it should also throw an error to the frontend.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: macOS Monterey
  • Browser [e.g. chrome, safari, electron app]: chrome
  • Browser version [e.g. 22]: 103
  • Backend branch [e.g. dev, v3b2 release]: dev
  • Frontend branch [e.g. dev, v3b2 release]: dev
@kswang1029 kswang1029 added the critical bug critical bug which is a showstopper for release label Jul 27, 2022
@kswang1029
Copy link
Contributor Author

@markccchiang could you have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
critical bug critical bug which is a showstopper for release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants