Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rogue pugixml-related files being installed #1261

Closed
ajm-ska opened this issue May 4, 2023 · 0 comments · Fixed by #1263
Closed

Rogue pugixml-related files being installed #1261

ajm-ska opened this issue May 4, 2023 · 0 comments · Fixed by #1263
Assignees
Labels
bug Something isn't working
Milestone

Comments

@ajm-ska
Copy link
Collaborator

ajm-ska commented May 4, 2023

Describe the bug
It has been noticed when we create a carta-backend RPM (and carta-backend Debian package), it makes and tries to install a bunch of pugixml related files. This should not happen because we only use pugixml as a third-party static dependency during build time. It should not be installing any files on the system.

For reference, the following is the error we get at the end of the rpmbuild stage listing the files in question:

Checking for unpackaged file(s): /usr/lib/rpm/check-files /root/rpmbuild/BUILDROOT/carta-backend-beta-4.0+2023.5.4-1.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/include/pugiconfig.hpp
   /usr/include/pugixml.hpp
   /usr/lib64/cmake/pugixml/pugixml-config-version.cmake
   /usr/lib64/cmake/pugixml/pugixml-config.cmake
   /usr/lib64/cmake/pugixml/pugixml-targets-release.cmake
   /usr/lib64/cmake/pugixml/pugixml-targets.cmake
   /usr/lib64/libpugixml.a
   /usr/lib64/pkgconfig/pugixml.pc

This problem was introduced when we began using pugixml as a third-party library in PR#1288

To Reproduce
Steps to reproduce the behavior:
(I haven't checked the following method, but I think it may work)

  1. Build a carta-backend
  2. Check the time stamp on/usr/lib64/libpugixml.a
  3. It may indicate that the file was freshly installed.

Expected behavior
During the carta-backend make process, the third-party pugixml library should not install any files on your system.

Platform info (please complete the following information):

  • OS [e.g. macOS Monterey]: CentOS7
  • Browser [e.g. chrome, safari, electron app]: not applicable
  • Browser version [e.g. 22]: not applicable
  • Backend branch [e.g. dev, v3b2 release]: v4.0.0-beta.1
  • Frontend branch [e.g. dev, v3b2 release]: not applicable
@ajm-ska ajm-ska added the bug Something isn't working label May 4, 2023
@kswang1029 kswang1029 added this to the v4.0-stable milestone May 11, 2023
@ajm-ska ajm-ska mentioned this issue May 11, 2023
5 tasks
@ajm-ska ajm-ska linked a pull request May 12, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants