Refactor cancel dialog confirmation check to service #1135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkangs0226
reviewed
Jan 18, 2023
There was a problem hiding this comment.
Thanks for your work! I have left a few comments for you.
Also, seems like there is an existing PR for the same issue, and because it has been made first, we should merge that PR first 😅 Thanks for looking into this regardless, I hope you are more familiar with our codebase now.
| * An interface that provides abstraction for components that can cancel | ||
| * edits. | ||
| */ | ||
| export interface EditCancellable { |
There was a problem hiding this comment.
Let's avoid exporting other interfaces/classes in service files.
| * @param component Component that implements `EditCancellable` | ||
| * @param isModified Callback function that checks if the field has actually been modified | ||
| */ | ||
| openCancelDialogIfModified<T extends EditCancellable>(component: T, isModified: () => boolean) { |
There was a problem hiding this comment.
If you look at the start of the file, you will see that the IResponsible for creating and updating issues, and periodically fetching issues using GitHub. It would be better to have this method under another file.
|
Closing this PR since work has already been done on the issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1024
Changes Made:
IssueServiceIssueServiceclass to reduce such code duplication.Proposed Commit Message: