Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting Style of issue-table component #1194

Open
Eclipse-Dominator opened this issue Jun 15, 2023 · 4 comments
Open

Formatting Style of issue-table component #1194

Eclipse-Dominator opened this issue Jun 15, 2023 · 4 comments

Comments

@Eclipse-Dominator
Copy link
Contributor

Eclipse-Dominator commented Jun 15, 2023

Describe the bug
When viewed in browser, a fully loaded issue-table seem render an incomplete table.
image

It might be better to show "end" of the table instead.

Cause
This issue is due to the table being on a separate elevation compared to the paginator with class="mat-elevation-z8".

Potential Solutions
Right now, there are a few approaches that comes to mind when rendering the table.

  1. Show the "end" of the table for all pages like for so:
    image
  2. Show the "end" of the table only for the last page
    image
  3. Make the paginator be on the same elevation as the table
    image

Options 1 and 3 are trivial to implement.
Option 1 involves add <br/> right before paginator in issue-table
Option 3 involves wrapping both table and paginator in a div with class="mat-elevation-z8"

Option 2 might take a bit more work but should be relatively easy to implement like 1 and 3.

@supermii2
Copy link

Hi! I'm thinking of working on CATcher, and the workflow mentioned that I should put a comment first.

May I work on this issue?

@chunweii
Copy link
Contributor

Sure, @supermii2

Let us know what option you intend to implement. I personally prefer option 1.

@Darkarche3
Copy link

Hi, may I know if anyone is actively resolving this issue?

@cheehongw
Copy link
Contributor

hi @Darkarche3, this issue is not being worked on currently.

Feel free to work on it unless it has been claimed by an existing contributor or member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants