Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pre-commit hook to validate JSON files #75

Closed
kelly-sovacool opened this issue Jan 3, 2024 · 0 comments · Fixed by #77
Closed

add pre-commit hook to validate JSON files #75

kelly-sovacool opened this issue Jan 3, 2024 · 0 comments · Fixed by #77
Assignees
Labels
RENEE RepoName
Milestone

Comments

@kelly-sovacool
Copy link
Member

#72 wasn't caught by a dry run because dry runs don't use cluster.json. We could try to catch syntax errors in our JSON files with a pre-commit hook.

@kopardev kopardev added the RENEE RepoName label Jan 3, 2024
@kelly-sovacool kelly-sovacool added this to the Jan 2024 milestone Jan 10, 2024
@kelly-sovacool kelly-sovacool self-assigned this Jan 10, 2024
@kopardev kopardev modified the milestones: Jan 2024, Jan 2025 Jan 24, 2024
@kelly-sovacool kelly-sovacool modified the milestones: Jan 2025, Jan 2024 Jan 24, 2024
@kopardev kopardev modified the milestones: Jan 2024, 2024-01 Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RENEE RepoName
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants