[BUG] Trajectories is wrong for various projectiles

[leumasme]

LiquidBounce Branch

Nextgen

LiquidBounce Build/Version

0.22.0

Operating System

Windows 10

Minecraft Version

1.21.1

Describe the bug

Trajectories is wrong for various entities

• XP Bottles: Both the preview and the trajectories on already flying xp bottles is wrong and show that the bottle would fly further than is reality, they appear to have more drag or gravity than is set in trajectories
• Trident: Preview does not respect the riptide enchantment, which completely removes the ability to throw the trident and replaces it with a dash ability
• Wind Charge: The preview trajectory is wrong, they do copy the player velocity but trajectories believes that they do not. (The initial velocity is probably wrong as well, but less relevant for rendering as they fly straight)
• Fishing Rod: The preview is wrong. When throwing forwards, it shows a much further throw than is actually real. When throwing (straight) downwards, it shows that the fishing bobber will go straight down even though it will always go forwards by a lot, even when throwing straight down
  
• Fishing Rod: Trajectories completely ignores that the fishing bobber floats instead of sinking
• Snowball: The drag in water is incorrect, they can go further in water than both preview and live tracers suggest.
• Splash potion: Incorrect in water, goes further than shown
• XP Bottle: Incorrect in water, goes further than shown
• Wind Charge: Incorrect in water, they are not slowed down by water but trajectories assumes so, causing the trajectory to stop after just a few blocks even on high simulated ticks numbers

In general, the first-person line preview of all projectiles is incorrect. The line appears to be offset to the right to make the curve more visible, but this also means the end destination is offset, and will often appear to hit a different block than the blue block hit marker. It should be rotated so that the start is offset to the side but the end is at the correct position.

Steps to reproduce

see above

Client Log

-

Screenshots

No response

[leumasme]

At least for 1.21.1:

• Potion dragInWater should be 0.8 instead of 0.6
• EXPBottle Gravity should be 0.07 instead of 0.05
• Snowball dragInWater should be 0.8 instead of 0.6
• Windcharge copiesPlayerVelocity should be true/unset
• Trident with riptide enchant should not show the preview trajectory
• ...
• Fishing rod needs some more complex handling

it should probably be refactored to call getDrag and getDragInWater directly?

[superblaubeere27]

Holy Hell!