Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take care of when should the bindings being regenerated #29

Closed
ldm0 opened this issue Jun 25, 2020 · 2 comments · Fixed by #30 or #83
Closed

Take care of when should the bindings being regenerated #29

ldm0 opened this issue Jun 25, 2020 · 2 comments · Fixed by #30 or #83
Assignees
@ldm0
Labels
blocked blocked on something like another PR enhancement New feature or request

Comments

@ldm0
Copy link
Member

ldm0 commented Jun 25, 2020

Currently we doesn't pay much attention on when should the bindings being regenerated and when should the project being build. For example we need to take care of the pkg_confg::Config::env_var.
@ldm0 ldm0 added the enhancement New feature or request label Jun 25, 2020
@ldm0 ldm0 self-assigned this Jun 25, 2020
@ldm0 ldm0 mentioned this issue Jul 3, 2020
Merged
@ldm0 ldm0 closed this as completed Jul 3, 2020
@ldm0 ldm0 reopened this Nov 3, 2020
@ldm0 ldm0 mentioned this issue Nov 3, 2020
Merged
@ldm0
Copy link
Member Author

ldm0 commented Nov 4, 2020 •
edited
Loading

Blocked on the issue: rust-lang/cargo#7432
Currently the project rebuilds constantly, the problem is my rust-analyzer uses cargo watch, and I uses cargo run with a different environment variable.

@ldm0
Copy link
Member Author

ldm0 commented Nov 4, 2020 •
edited
Loading

I worked around it by not listening to these environment variables. rusqlite took the same way: rusqlite/rusqlite#627

@ldm0 ldm0 added the blocked blocked on something like another PR label Nov 6, 2020
@ldm0 ldm0 mentioned this issue Mar 13, 2023
Merged
@ldm0 ldm0 closed this as completed in #83 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldm0 ldm0

Labels
blocked blocked on something like another PR enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@ldm0