Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

Time constraint is being ignored for data download if entered in wrong format #345

Closed
HelenClifton opened this issue Sep 6, 2017 · 6 comments

Comments

@HelenClifton
Copy link

Expected behavior

Downloading soil moisture dataset and applying time constraint

Actual behavior

Time constraint is ignored
May be because "From" and "To" are no longer separate fields in "Download Data Source" window

Steps to reproduce the problem

  1. Download Data Source as below:

time

  1. Look in local data store, see files from 1978 onwards are being saved

Specifications

cate-0.9.0.dev6
Windows 7 Professional

@mzuehlke
Copy link
Collaborator

mzuehlke commented Sep 6, 2017

Hi Helen,
before entering a date range in the input field the hint shows the format as YYYY-MM-DD,YYYY-MM-DD.
Maybe I should format the text below the input field in a similar format.

@mzuehlke mzuehlke self-assigned this Sep 6, 2017
@HelenClifton
Copy link
Author

@mzuehlke Hi, thanks for this.
When I put the time range in the correct format, the time constraints are applied correctly.
It would also be a good idea, if the format is incorrect, to warn the user, rather than ignoring the input and downloading the entire dataset (which can take several hours)

@HelenClifton HelenClifton changed the title Time constraint is being ignored for data download Time constraint is being ignored for data download if entered in wrong format Sep 7, 2017
@mzuehlke
Copy link
Collaborator

mzuehlke commented Sep 7, 2017

Yes, you are right. I'm already looking into the missing validation.

@mzuehlke mzuehlke removed the blocker label Sep 7, 2017
@forman
Copy link
Member

forman commented Sep 13, 2017

@mzuehlke

Maybe I should format the text below the input field in a similar format.

Definitely not a maybe. I'll fix it.

@forman
Copy link
Member

forman commented Sep 25, 2017

Will be closed with #374

@HelenClifton
Copy link
Author

Confirmed fixed in cate-1.0.0-dev.1. Format is now validated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants