Skip to content
This repository has been archived by the owner on Aug 29, 2023. It is now read-only.

"Save Workspace As" does not work #419

Closed
forman opened this issue Sep 25, 2017 · 10 comments
Closed

"Save Workspace As" does not work #419

forman opened this issue Sep 25, 2017 · 10 comments
Assignees
Milestone

Comments

@forman
Copy link
Member

forman commented Sep 25, 2017

From @HelenClifton on June 20, 2017 11:10

When File->Save Workspace As is selected, there isn't a way to enter the name for the new workspace.
capture

If "Select" is clicked, an error message is shown

capture

Copied from original issue: CCI-Tools/cate-desktop#14

@forman
Copy link
Member Author

forman commented Sep 25, 2017

Yes, a known problem. To get around it: create an empty directory first and then select its name.

We actually need a directory chooser.

@forman forman added this to the IRM7 milestone Sep 25, 2017
@forman forman self-assigned this Sep 25, 2017
@forman forman added the ws label Sep 25, 2017
@forman
Copy link
Member Author

forman commented Dec 14, 2017

@HelenClifton unfortunately there is currently no real fix for that, because the Electron platform does not allow us selecting non-existing directories. See electron/electron#9411.

To all: are there any suggestions how to proceed?

@HelenClifton
Copy link

@forman : The user probably will not know in advance that they need to create a new folder.
So, the suggestion is: the user navigates to the workspace home (the folder where the new workspace will be) and then a pop up appears asking the user to enter a name for the new workspace.

@forman
Copy link
Member Author

forman commented Dec 15, 2017

That sounds reasonable. What about a dialog that looks like this:

+------------------------------------------------------------------+
|    New Workspace                                               X |
+------------------------------------------------------------------+
|                                                                  |
|    Parent directory:                                             |
|                                                        +-----+   |
|    ________________________________________________    | ... |   |
|                                                        +-----+   |
|                                                                  |
|    Workspace name:                                               |
|                                                                  |
|    ________________________________________________              |
|                                                                  |
|                                                                  |
|                                   +--------+        +--------+   |
|                                   |   OK   |        | Cancel |   |
|                                   +--------+        +--------+   |
|                                                                  |
+------------------------------------------------------------------+

@HelenClifton
Copy link

Looks fine to me !

@forman
Copy link
Member Author

forman commented Dec 19, 2017

Fixed in 1.0.1 as proposed.

@forman forman closed this as completed Dec 19, 2017
@HelenClifton
Copy link

@forman Tested with cate-2.2.0-dev.1 - not quite as expected - please could you take a look ?

  1. File->New Workspace
  2. Select an empty folder as the parent folder, enter a new workspace name
    capture1
  3. Workspace is created. Then select "Download Data Source"
    capture2
  4. Click Download and see error:
    capture3
    Traceback is here: Traceback.txt

@forman
Copy link
Member Author

forman commented Mar 9, 2018

Does the UC09 folder exist?

@HelenClifton
Copy link

@forman If I create the UC09 folder first, then it's fine.
Later on if I choose File->Save Workspace As, it will create a new sub-folder within the parent directory, as expected.

@forman
Copy link
Member Author

forman commented Mar 13, 2018

Strange. It works for me, even if the workspace folder does not exist. But the parent must exist.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants