Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDoE Usability Suggestion: Remove data imputation fields when there are no missing values #993

Closed
sspoon opened this issue Jan 3, 2022 · 2 comments · Fixed by #996
Closed
Assignees
Labels
FOQUS GUI Issues related to information displayed on the GUI, or broken buttons Priority:Normal Normal Priority Issue or PR SDoE Sequential Design of Experiments

Comments

@sspoon
Copy link

sspoon commented Jan 3, 2022

When loading a candidate set, the table describing the loaded files contains a workflow related to data imputation for missing values. If there are no missing values, these fields appear as inactive fields. If data imputation is needed, then the fields become active. See the inactive fields in the red boxes below:
imputation

imputation2

I would suggest instead to only show these fields if data imputation is needed, instead of having these fields inactive. It's unclear at this point how often the data imputation feature is needed, and having these fields inactive by default makes users feel that they have incomplete tasks at hand. So the default use case (no data imputation) would look like this:

1U_starting_screen

Then the fields can be added if data imputation is needed.

If it becomes the case that data imputation is a common use case, I would suggest removing the workflow from the table entirely and moving it into a dialog window. But I think we should address this only if it becomes a more common use case.

@ksbeattie ksbeattie added Priority:Normal Normal Priority Issue or PR FOQUS GUI Issues related to information displayed on the GUI, or broken buttons SDoE Sequential Design of Experiments labels Jan 4, 2022
@sotorrio1 sotorrio1 linked a pull request Jan 6, 2022 that will close this issue
@ksbeattie
Copy link
Member

@sspoon, could you review that @sotorrio1 fix is correct?

@ksbeattie ksbeattie reopened this Jan 11, 2022
@sspoon
Copy link
Author

sspoon commented Jan 12, 2022

@ksbeattie @sotorrio1 The fix looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FOQUS GUI Issues related to information displayed on the GUI, or broken buttons Priority:Normal Normal Priority Issue or PR SDoE Sequential Design of Experiments
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants