Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyClimate uses old Numeric code #800

Closed
tammasloughran opened this issue Oct 14, 2014 · 9 comments
Closed

PyClimate uses old Numeric code #800

tammasloughran opened this issue Oct 14, 2014 · 9 comments
Assignees
Labels
Milestone

Comments

@tammasloughran
Copy link

Hi,
UVCDAT includes the pyclimate module that has some functions for doing PCA and CCA that I would like to use. This module is getting a bit old now seeing as though it still uses the old Numeric code via the numpy.oldnumeric module in most of its features. It seems with the latest release of numpy support for numpy.oldnumeric has been dropped which means that importing most of the pyclimate modules results in:
ImportError: No module named oldnumeric.

Cheers

@aashish24 aashish24 added this to the 2.1 milestone Oct 14, 2014
@aashish24
Copy link
Contributor

Thanks for the report. Added it for 2.1

@tammasloughran
Copy link
Author

Doesnt seem like there's any online repository for this and the original authors havn't made any updates in 6 years. So I made one and made changes to it.
https://github.com/tammasloughran/PyClimateUpdate
I removed all references to numpy.oldnumeric and changed all the functions and attribute names to the equivalents in the newest numpy. I also removed Scientific because its also dependant on numpy.oldnumeric, besides, Scientific it isnt even used in it anyway appart from its netcdf function.
It compiles and seems to work but I havn't had any chance to fully test it and validate results from it.

@doutriaux1 doutriaux1 added the Bug label Oct 14, 2014
@doutriaux1 doutriaux1 self-assigned this Oct 14, 2014
@doutriaux1
Copy link
Contributor

Wow! thank you so much @tammasloughran this is really helpful, I will test and make sure we integrate this into our next release 2.1

@tammasloughran
Copy link
Author

Sorry, this has already been done I think.
http://uv-cdat.llnl.gov/cdat/resources/PyClimate-1.2.3.tar.gz
Looks like uvcdat no longer installs pyclimate anymore so I was was using the old version from http://fisica.ehu.es/pyclimate. Is there any reason why it's not used anymore?

Note PyClimate-1.2.3 still imports Scientific.Statistics but doesn't actually use it.

@doutriaux1
Copy link
Contributor

@tammasloughran i think it is still install if you use CDAT_BUILD_MODE=ALL. I will double check though.

@doutriaux1 doutriaux1 reopened this Nov 10, 2014
@doutriaux1 doutriaux1 modified the milestones: 2.2, 2.1 Nov 10, 2014
@doutriaux1
Copy link
Contributor

@aashish24 I can't seem to be able to trigger the build of pyclimate, assiging this to you.

@doutriaux1 doutriaux1 assigned aashish24 and unassigned doutriaux1 Feb 17, 2015
@doutriaux1
Copy link
Contributor

@aashish24 i think this suffers the same issue as the h5py the cdat_add_package_denedent never triggers it.
see comment sin #1035

@aashish24
Copy link
Contributor

Okay, I will have a look at it.

@durack1
Copy link
Member

durack1 commented Feb 27, 2015

@doutriaux1 @aashish24 #1071 duplicates this so I think it's a candidate for closure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants