Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] [Bug] Update submission function in py script not checking for GB flag #242

Closed
jessicarowell opened this issue Jan 6, 2025 · 1 comment · Fixed by #244
Closed

[Internal] [Bug] Update submission function in py script not checking for GB flag #242

jessicarowell opened this issue Jan 6, 2025 · 1 comment · Fixed by #244
Assignees
@jessicarowell
Labels
bug Something isn't working
Milestone
v4.1.0

Comments

@jessicarowell
Copy link
Collaborator

Description.
conditional statement where update flag is set only checks for ftp_upload = True, so it runs a check for Genbank even if the user didn't submit to GB

Run environment (container, cloud service, HPC, platform, etc.)

Command to replicate the error:

Any Additional Context or Information?
@jessicarowell jessicarowell added the bug Something isn't working label Jan 6, 2025
@jessicarowell jessicarowell added this to the v4.1.0 milestone Jan 6, 2025
@jessicarowell jessicarowell self-assigned this Jan 6, 2025
@jessicarowell jessicarowell linked a pull request Jan 6, 2025 that will close this issue
Patch that fixes several bugs in metadata validation and submission #244
Merged
4 tasks
@jessicarowell
Copy link
Collaborator Author

Fixed on ick4-dev-patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessicarowell jessicarowell

Labels
bug Something isn't working
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging a pull request may close this issue.

Patch that fixes several bugs in metadata validation and submission CDCgov/tostadas
1 participant
@jessicarowell