Change logging exception to logging error, at least for HTTPErrors #835
Conversation
…ot sure about the other change, I'll ask Dave
…tead of exception.
…tead of exception.
…es-for-common-httperrors-400-ish-and-500-ish-status-codes-and-bad-certificates
…he way down the stack) and adding test_logging.py management command.
…ces all the time.
|
Hi @datadavev I'd talked with Adam about changes for now and he said we should proceed with the first step of reducing Let me know if you see problems with the changes here since I just incorporated them here. I can move to a different PR if you'd like me to, instead. |
|
I tested the link checker on dev and the logging is significantly reduced. (See the issue for a few notes.) I think I'll deploy to stage and I think we should go ahead with this to production later this week unless there is some real reason not to. |
|
@sfisher Hi Scott, Changes look good. Please go ahead merge and deploy on prod. Jing |
Hi Dave,
Thanks for your feedback. You can see I've changed IncompleteRead, HTTPError and the exception branch to use
log.error()instead oflog.exception()and some use the simple_error() method which just logs the exception name, line number and optionally a status code if it's an HTTPError.Does this seem reasonable to you?
I tested out the simple_error() method manually and it all seems to work ok.
Let me know what you think and I'll maybe try it on dev.