Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipping is broken #24

Closed
jacobly0 opened this issue Sep 3, 2016 · 4 comments
Closed

Clipping is broken #24

jacobly0 opened this issue Sep 3, 2016 · 4 comments

Comments

@jacobly0
Copy link
Member

jacobly0 commented Sep 3, 2016

One comment says the clip region is inclusive, however the default clip region (0, 0, lcdWidth, lcdHeight) is exclusive.

@adriweb
Copy link
Member

adriweb commented Sep 3, 2016

As said on IRC, since the current function relies on a pair of points instead of point + w/h, a solution to this is to introduce: void gfx_SetClipRect(int xmin, int ymin, unsigned int width, unsigned int height); as we cannot break compatibility with older versions.
(However, should the default clipping window be fixed to be (0, 0, 319, 239)?

@mateoconlechuga
Copy link
Member

Or just make things exclusive. This is really only broken for lines at the moment, and it doesn't really have an affect on output.

@mateoconlechuga
Copy link
Member

Partially fixed and tested with 7d3e9d7, need to run a few more tests though

@mateoconlechuga
Copy link
Member

Good to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants