-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculation of cloudsat_preclvl_index fails when use_vgrid=.false. #68
Comments
This bug has uncovered a lack of robustness in the calculation of some CALIPSO diagnostics. Some diagnostics produce wrong results when requested on model levels. This could be because they shouldn't be calculated on model levels or because the calculations are have bugs. If the former we need some quality control that checks for consistency between the requested configuration and outputs. I haven't fixed this in this change, I've created a new test (Global UM with diagnostics on model levels) that doesn't request the problematic diagnostics: |
As part of this change, I've made some minor changes to plot_test_outputs.py so that it doesn't fail when variables are not present in the output file. |
@alejandrobodas |
PR #69 only partially addresses the issues raised here, so I'm reopening this issue. |
The error is caused by the calculation of cospIN%fracPrecipIce at the end of the the CloudSat radar optics section in subsample_and_optics, between L870 and L887. If this diagnostic can only be calculated for the CloudSat grid, then this needs to be protected by an IF test. The error can be seen in this CI test.
The text was updated successfully, but these errors were encountered: