Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGAL Lab bugs #6690

Open
16 of 69 tasks
MaelRL opened this issue Jun 21, 2022 · 9 comments
Open
16 of 69 tasks

CGAL Lab bugs #6690

MaelRL opened this issue Jun 21, 2022 · 9 comments

Comments

@MaelRL
Copy link
Member

MaelRL commented Jun 21, 2022

Issue Details

Sorted by estimated amount of work / complexity.

Large

Medium

Small

  1. Bug CGAL 3D demo
    lrineau
@MaelRL
Copy link
Member Author

MaelRL commented Aug 13, 2022

  1. Generate 2 spheres with the demo's generator. Respective radii 1 and 0.5, 4 iterations of subdivision
  2. Mesh_3 with no sharp features, facet and cell size 0.03
  3. segfault

@afabri

This comment was marked as duplicate.

@afabri
Copy link
Member

afabri commented Aug 17, 2022

When remeshing a surface the result should be drawn double sided.

@afabri
Copy link
Member

afabri commented Aug 22, 2022

Concerning the inflate I changed it to only work if a single polyhedron item is selected. It should be easy to put a loop around. As an inflated mesh has quickly self intersections I am wondering if the proposed inflate distance should not be a fraction of the average edge length and not a fraction of the bbox diagonal. @sloriot any opinion?

@afabri
Copy link
Member

afabri commented Aug 22, 2022

  1. Generate 2 spheres with the demo's generator. Respective radii 1 and 0.5, 4 iterations of subdivision

    1. Mesh_3 with no sharp features, facet and cell size 0.03

    2. segfault

Sqrt3 subdivision?

@afabri
Copy link
Member

afabri commented Aug 22, 2022

image

@afabri
Copy link
Member

afabri commented Aug 22, 2022

works for me,

@sloriot
Copy link
Member

sloriot commented Aug 22, 2022

Concerning the inflate I changed it to only work if a single polyhedron item is selected. It should be easy to put a loop around. As an inflated mesh has quickly self intersections I am wondering if the proposed inflate distance should not be a fraction of the average edge length and not a fraction of the bbox diagonal. @sloriot any opinion?

If you mean the default value, the bbox makes more sense. If you want to avoid self-intersections then you are interested in the lfs...

@afabri
Copy link
Member

afabri commented Jan 4, 2023

The average angle computation is fixed by #7161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants